Skip to content

feat(data-warehouse): wire Intercom and HubSpot into the self-driving inbox#3614

Merged
trunk-io[bot] merged 1 commit into
mainfrom
tom/inbox-oauth-wiring
Jul 22, 2026
Merged

feat(data-warehouse): wire Intercom and HubSpot into the self-driving inbox#3614
trunk-io[bot] merged 1 commit into
mainfrom
tom/inbox-oauth-wiring

Conversation

@Gilbert09

Copy link
Copy Markdown
Member

Problem

Intercom and HubSpot are the two OAuth-connected support sources deferred from the initial
30-source inbox batch (#3597). With the generic OAuth flow starter in place
(#3613), they can be wired in like any other source.

Changes

Two entries in the shared EXTERNAL_INBOX_SOURCES registry (setup: "dynamic"), plus the
matching SourceProduct/ToggleableSourceProduct, SignalSourceConfig.source_product, and
analytics-event unions, and their icon metadata. No bespoke setup form: DynamicSourceSetup
renders each source's oauth field generically and the generic integration router starts the
flow by kind.

How did you test this?

  • turbo typecheck for @posthog/ui, @posthog/core, @posthog/shared, @posthog/api-client,
    @posthog/mobile — pass.
  • pnpm --filter @posthog/shared build; biome check on changed files — clean.

Dependencies

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit b98cefc.

Base automatically changed from tom/inbox-tier1-sources to main July 21, 2026 17:06
@trunk-io

trunk-io Bot commented Jul 21, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@Gilbert09
Gilbert09 force-pushed the tom/inbox-oauth-wiring branch from 97614bd to 7dfedac Compare July 21, 2026 17:48
… inbox

Add Intercom and HubSpot as inbox source toggles. Both are OAuth sources,
but that needs no bespoke UI: the generic DynamicSourceSetup renders their
connect form's oauth field, and the generic integration flow starter
(separate PR) launches the OAuth flow by kind. So this is the same
one-registry-entry change as any credential source — two entries in
EXTERNAL_INBOX_SOURCES plus the SourceProduct/analytics unions and icons.
@Gilbert09
Gilbert09 force-pushed the tom/inbox-oauth-wiring branch from 7dfedac to b98cefc Compare July 22, 2026 11:02
@Gilbert09 Gilbert09 added the Stamphog This will request an autostamp by stamphog on small changes label Jul 22, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, purely additive data/config entries (registry rows and icon metadata) with no logic changes; matches the PR description, no showstoppers.

Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 20L, 2F substantive — within ceiling
tier T1-agent / T1a-trivial (20L, 2F, single-area, feat)
stamphog 2.0.0b3 .stamphog/policy.yml @ fb1d37c · reviewed head b98cefc

@trunk-io
trunk-io Bot merged commit 0111e82 into main Jul 22, 2026
40 checks passed
@trunk-io
trunk-io Bot deleted the tom/inbox-oauth-wiring branch July 22, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant